Skip to content

🐛 Prevent showing full s3 url with credentials in logs #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2025
Merged

🐛 Prevent showing full s3 url with credentials in logs #8493

merged 5 commits into from
Oct 13, 2025

Conversation

@wvangeit
Copy link
Contributor

@wvangeit wvangeit commented Oct 9, 2025 •
edited by pcrespov
Loading

What do these changes do?

As per #5979
the logs were show urls with full credentials with downloading a file.
I changed it to only show the server and file path.

Related issue/s

How to test

Download file in service, url should not show credentials.

Dev-ops

No changes

@wvangeit wvangeit added this to the Cheops milestone Oct 9, 2025
@wvangeit wvangeit self-assigned this Oct 9, 2025
@wvangeit wvangeit added security Pull requests that address a security vulnerability a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels Oct 9, 2025
@wvangeit wvangeit changed the title Prevent showing fulling s3 url with credentials in logs 🐛 Prevent showing full s3 url with credentials in logs 🐛 Oct 9, 2025
@wvangeit
Copy link
Contributor Author

wvangeit commented Oct 9, 2025

Closes #5979

@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.72%. Comparing base (b01bc0d) to head (ed711ad).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b01bc0d) and HEAD (ed711ad). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (b01bc0d) HEAD (ed711ad)
unittests 32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8493       +/-   ##
===========================================
- Coverage   87.62%   66.72%   -20.90%     
===========================================
  Files        2001      795     -1206     
  Lines       77919    36265    -41654     
  Branches     1338      175     -1163     
===========================================
- Hits        68273    24198    -44075     
- Misses       9246    12010     +2764     
+ Partials      400       57      -343
Flag Coverage Δ
integrationtests 64.09% <ø> (-0.04%) ⬇️
unittests 91.82% <100.00%> (+5.50%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.63% <ø> (-8.26%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar 91.82% <100.00%> (+0.23%) ⬆️
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.04% <ø> (-12.94%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.89% <ø> (-8.55%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.11% <ø> (-28.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01bc0d...ed711ad. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title Prevent showing full s3 url with credentials in logs 🐛 🐛 Prevent showing full s3 url with credentials in logs Oct 9, 2025
pcrespov
pcrespov approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.

Took the liberty to modify your PR description and title to follow our https://github.com/itisfoundation/osparc-simcore/blob/3db0e34fa7d84ab431a9546f690db9d945388c96/.github/PULL_REQUEST_TEMPLATE.md

  • prefix icon in the itle
  • enumerate related issues so they display
  • prefix issue with closes, fixes or resolve to auto-close the references

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for ed711ad.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 2 View View

bisgaard-itis
bisgaard-itis approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@wvangeit wvangeit added the 🤖-automerge marks PR as ready to be merged for Mergify label Oct 13, 2025
@wvangeit
Copy link
Contributor Author

@mergify queue

@wvangeit wvangeit enabled auto-merge (squash) October 13, 2025 06:46
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sanderegg
sanderegg approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wvangeit wvangeit merged commit 3632ac8 into ITISFoundation:master Oct 13, 2025
193 of 201 checks passed
This was referenced Oct 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@wvangeit wvangeit

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:dask-service Any of the dask services: dask-scheduler/sidecar or worker security Pull requests that address a security vulnerability

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

4 participants

@wvangeit @pcrespov @sanderegg @bisgaard-itis